Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datanames in vignettes #1434

Merged
merged 14 commits into from
Jan 8, 2025
Merged

Datanames in vignettes #1434

merged 14 commits into from
Jan 8, 2025

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Dec 19, 2024 •
edited
Loading

closing #1380 and insightsengineering/teal.data#338

  • removes set_datanames
  • mentions dot-prefix to exclude dataset

@gogonzo gogonzo added the core label Dec 19, 2024
@gogonzo gogonzo marked this pull request as draft December 19, 2024 12:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  67      11  83.58%   41, 43, 85-93
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             99      42  57.58%   149-158, 160, 172-193, 218-221, 228-234, 237-238, 240
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             203      37  81.77%   26-54, 68, 78, 232, 263-267
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              227      85  62.56%   40-136, 168, 193-195, 312, 346
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 303-317, 320-331, 334-340, 354
R/module_teal_data.R                149      76  48.99%   44-150
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     195      87  55.38%   48-143, 158, 184-185, 224
R/module_transform_data.R           110       4  96.36%   20, 59, 129-130
R/modules.R                         267      60  77.53%   169-173, 228-231, 354-374, 382, 532-538, 551-559, 574-589, 622, 634-642
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    55-738
R/utils.R                           245      38  84.49%   391-440
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3311    1317  60.22%

Diff against main

Filename       Stmts    Miss  Cover
-----------  -------  ------  -------
R/modules.R      -11     -11  +3.07%
TOTAL            -11     -11  +0.20%

Results for commit: 5cc7110

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Unit Tests Summary

  1 files   27 suites   10m 34s ⏱️
275 tests 257 ✅ 18 💤 0 ❌
501 runs  483 ✅ 18 💤 0 ❌

Results for commit 3102fb3.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $147.40$ $+3.94$ $0$ $0$ $0$ $0$
shinytest2-data_summary 💔 $49.72$ $+1.68$ $0$ $0$ $0$ $0$
shinytest2-landing_popup 💔 $43.49$ $+1.15$ $0$ $0$ $0$ $0$
shinytest2-module_bookmark_manager 💔 $34.20$ $+1.32$ $0$ $0$ $0$ $0$
shinytest2-modules 💔 $37.61$ $+1.04$ $0$ $0$ $0$ $0$

Results for commit 59090b8

♻️ This comment has been updated with latest results.

@gogonzo gogonzo changed the title 338 datanames in vignettes Datanames in vignettes Dec 19, 2024
@gogonzo gogonzo marked this pull request as ready for review December 19, 2024 16:07
averissimo
averissimo reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ready to be merged as is.

1 comment on a mis-formating.

Left 2 comments to be more specific on the documentation, but they may be too verbose, not required though

R/modules.R Show resolved Hide resolved
vignettes/including-data-in-teal-applications.Rmd Outdated Show resolved Hide resolved
vignettes/including-data-in-teal-applications.Rmd Show resolved Hide resolved
averissimo
averissimo approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

gogonzo and others added 2 commits January 8, 2025 14:05
@gogonzo @averissimo
Update vignettes/including-data-in-teal-applications.Rmd
62c455c 
Co-authored-by: André Veríssimo <[email protected]>
Signed-off-by: Dawid Kałędkowski <[email protected]>
@gogonzo
restart cicd
3102fb3
@gogonzo gogonzo enabled auto-merge (squash) January 8, 2025 14:58
@gogonzo gogonzo merged commit b364ef4 into main Jan 8, 2025
28 checks passed
@gogonzo gogonzo deleted the 338_datanames_in_vignettes branch January 8, 2025 15:15
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@averissimo averissimo averissimo approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gogonzo @averissimo